vk: Handle VK_ERROR_FRAGMENTATION when allocating descriptor pools #14012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporarily relegating to draft. I fixed my windows 11 install on the intel machine, and I think there are better ways to handle the out of pool issue without spiking down to single digit fps every few seconds. |
- It is very likely that the resource would be available if we just waited a while for the GPU queue to clear. - Instead of also discarding the current work, first check if we can get by without a hard sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intel driver only support 1 million descriptor objects (we use update-after-bind everywhere) which sounds like a lot until you consider that we consume something like 50 of them every draw call. The moment a complex scene appears the driver implodes.
This fix adds a fallback in the form of a full stall to reset the queues. The downside to this is that intel GPUs will never be able to render high-draw-call-count titles at any reasonable framerates. Anything with over 10k draws will just crater.
Fixes #13997